[ https://issues.apache.org/jira/browse/MAPREDUCE-4974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574347#comment-13574347 ]
Karthik Kambatla commented on MAPREDUCE-4974: --------------------------------------------- Looks like calling {{#nextKeyValue()}} after it has already returned false will throw a NPE. IIUC, it should continue to return false. > Optimising the LineRecordReader initialize() method > --------------------------------------------------- > > Key: MAPREDUCE-4974 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4974 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1, mrv2, performance > Affects Versions: 2.0.2-alpha, 0.23.5 > Environment: Hadoop Linux > Reporter: Arun A K > Assignee: Gelesh > Labels: patch, performance > Fix For: 0.20.204.0, 0.24.0 > > Attachments: MAPREDUCE-4974.1.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > I found there is a a scope of optimizing the code, over initialize() if we > have compressionCodecs & codec instantiated only if its a compressed input. > Mean while Gelesh George Omathil, added if we could avoid the null check of > key & value. This would time save, since for every next key value generation, > null check is done. The intention being to instantiate only once and avoid > NPE as well. Hope both could be met if initialize key & value over > initialize() method. We both have worked on it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira