[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627037#comment-13627037
 ] 

Thomas Graves commented on MAPREDUCE-5015:
------------------------------------------

Some minor nits:

TestMRJobClient  - testfailTask (possibly others also - fix spelling of 
completed in the comment - "task complited !"
TestMRJobClient  - testfailTask and others in the file - In the places you 
catch an exception and assert that you caught the exception you should add a 
fail if it doesn't throw.

branch-2 and branch-0.23 patches remove commented out line: // JobID jobId = 
job.getJobID();
                
> Coverage fix for org.apache.hadoop.mapreduce.tools.CLI
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-5015
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5015
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>    Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.5
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>         Attachments: MAPREDUCE-5015-branch-0.23-a.patch, 
> MAPREDUCE-5015-branch-0.23.patch, MAPREDUCE-5015-branch-2-a.patch, 
> MAPREDUCE-5015-branch-2.patch, MAPREDUCE-5015-trunk-a.patch, 
> MAPREDUCE-5015-trunk.patch
>
>
> Coverage fix for org.apache.hadoop.mapreduce.tools.CLI
> MAPREDUCE-5015-trunk.patch patch for trunk
> MAPREDUCE-5015-branch-2.patch for branch-2
> MAPREDUCE-5015-branch-0.23.patch for branch-0.23

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to