[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhijie Shen updated MAPREDUCE-5157:
-----------------------------------

    Attachment: MAPREDUCE-5157.1.patch

I've uploaded a patch, which adds Sampler and its implementations (the code in 
branch-1) back to mapred.lib.InputSampler. A smaller difference is that 
mapred.lib.InputSampler.Sampler and its implementations extends their 
corresponding classes in mapreduce.lib.partition.InputSampler.

Also, the tests of calling Sampler in mapred.lib.InputSampler are added. 
Moreover, I've done binary compatibility test locally. Sort in hadoo-1.x 
examples jar can be run on Yarn with the patch.

In addition, I've one concern that mapred.lib.InputSampler may not be the only 
class that starts to extend its corresponding class in mapreduce.lib, and move 
its inner interfaces/classes to the superclass after upgrading to V2. If other 
classes do the same refactoring, the old M/R jobs that use these classes may 
not find their inner interfaces/classes as well.
                
> Sort in hadoop-1 examples is not binary compatible with hadoop-2 mapred.lib
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5157
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5157
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: MAPREDUCE-5157.1.patch
>
>
> In SORT example, org.apache.hadoop.mapred.lib.InputSampler.Sampler is used in 
> hadoop-1. However, after upgrading to hadoop-2, 
> org.apache.hadoop.mapred.lib.InputSampler is modified to extend 
> org.apache.hadoop.mapreduce.lib.partition.InputSampler, and the inner class, 
> Sampler, has been moved to the superclass. Therefore, hadoop-1 SORT can not 
> find Sampler when it runs with hadoop-2 framework.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to