[
https://issues.apache.org/jira/browse/MAPREDUCE-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13648251#comment-13648251
]
Arun C Murthy commented on MAPREDUCE-4366:
------------------------------------------
bq. Oof this was a grueling one
[~sandyr] Thanks for getting to the bottom of this one.
The patch looks good, couple of nits:
{noformat}
@@ -3019,14 +3016,24 @@ public class JobInProgress {
// hence we are decrementing the same set.
// Except after garbageCollect in a different thread.
if (!tip.isJobCleanupTask() && !tip.isJobSetupTask()) {
+ boolean incWaiting = !isComplete && !isComplete() &&
+ tip.getActiveTasks().isEmpty();
+ boolean wasSpeculative = wasComplete ||
!tip.getActiveTasks().isEmpty();
+
{noformat}
This hunk - maybe we should rename the local variable to 'isTipComplete' ? That
threw me off! :)
Next, the change to move decrement of speculative(Map,Reduce)Tasks - can you
please help me understand why that was required?
----
Once again, thanks!
> mapred metrics shows negative count of waiting maps and reduces
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-4366
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4366
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 1.0.2
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Attachments: MAPREDUCE-4366-branch-1.patch
>
>
> Negative waiting_maps and waiting_reduces count is observed in the mapred
> metrics. MAPREDUCE-1238 partially fixed this but it appears there is still
> issues as we are seeing it, but not as bad.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
