[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653506#comment-13653506
 ] 

Lohit Vijayarenu commented on MAPREDUCE-5232:
---------------------------------------------

Patch looks good. Two minor things I could think of
1.  
{noformat}
    if (conf.getBoolean(MRJobConfig.MAPREDUCE_CHILD_LOG_PROPERTIES_ON_START, 
false)) {
{noformat}
Default define in .xml is true, while code works on false. Code should probably 
reflect what is in default.xml

2. Instead of having 2 separate configs, we can get away with just 
mapreduce.child.log.properties. If that is set, then we log, if that is empty, 
then the feature is disable. 

                
> log classpath and other key properties on child JVM start
> ---------------------------------------------------------
>
>                 Key: MAPREDUCE-5232
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5232
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv1, mrv2
>    Affects Versions: 2.0.4-alpha
>            Reporter: Sangjin Lee
>         Attachments: MAPREDUCE-5232-branch-2.patch, MAPREDUCE-5232.patch
>
>
> It would be great if we log vital information such as classpath, etc. upon a 
> mapreduce child JVM start. This would help a great deal in terms of 
> troubleshooting classpath issues, etc. Today it is pretty difficult to debug 
> this unless you preserve the container script.
> Maybe it can log things like classpath, os name/version, java version, etc. 
> at the beginning of the child JVM start.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to