[ https://issues.apache.org/jira/browse/MAPREDUCE-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod Kumar Vavilapalli updated MAPREDUCE-5130: ----------------------------------------------- Status: Open (was: Patch Available) We can close MAPREDUCE-5236 as a duplicate. Comments on the latest patch: Overall, don't do more changes than necessary. Just change the defaults, and deprecate the DISABLED_MEMORY_LIMIT. If you just do this the following issues will be taken care of automatically - You can leave around the comment from getMemoryForMapTask() and getMemoryForReduceTask() and instead of -1, refer to the default property. - JobConf.normalizeMemoryConfigValue() is public, shouldn't be removed. - When someone gives a negative value for the vmem properties, we should just use the default one. - Given above, testNegativeValuesForMemoryParams() should be modified instead of removing completely. One minor question: - Why remove the timeout for testJobConf()? You missed this bq. mapreduce.job.jvm.numtasks isn't supported in MR over YARN. > Add missing job config options to mapred-default.xml > ---------------------------------------------------- > > Key: MAPREDUCE-5130 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5130 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: documentation > Affects Versions: 2.0.4-alpha > Reporter: Sandy Ryza > Assignee: Sandy Ryza > Attachments: MAPREDUCE-5130-1.patch, MAPREDUCE-5130-1.patch, > MAPREDUCE-5130-2.patch, MAPREDUCE-5130-3.patch, MAPREDUCE-5130.patch > > > I came across that mapreduce.map.child.java.opts and > mapreduce.reduce.child.java.opts were missing in mapred-default.xml. I'll do > a fuller sweep to see what else is missing before posting a patch. > List so far: > mapreduce.map/reduce.child.java.opts > mapreduce.map/reduce.memory.mb > mapreduce.job.jvm.numtasks > mapreduce.input.lineinputformat.linespermap > mapreduce.task.combine.progress.records -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira