[ https://issues.apache.org/jira/browse/MAPREDUCE-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670936#comment-13670936 ]
Hadoop QA commented on MAPREDUCE-5283: -------------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12585497/MAPREDUCE-5283.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 15 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs: org.apache.hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobsQuery {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3701//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3701//console This message is automatically generated. > Over 10 different tests have near identical implementations of AppContext > ------------------------------------------------------------------------- > > Key: MAPREDUCE-5283 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5283 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: applicationmaster, test > Affects Versions: 2.0.4-alpha > Reporter: Sandy Ryza > Assignee: Sandy Ryza > Attachments: MAPREDUCE-5283.patch > > > I'm trying to add a method to AppContext for MAPREDUCE-5171, and I have to go > into nearly every test file for MR web services to make sure their > TestAppContext implements it. I propose having a common implementation of > AppContext that all these tests can use. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira