[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677654#comment-13677654
 ] 

Sandy Ryza commented on MAPREDUCE-5184:
---------------------------------------

Thanks, [~zjshen], a few more nitpicks:

{code}
+  no major surgery has been conducted on it. Therefore, MRv2 is able to ensure
+  satisfactory compatibility to MRv1 applications. However, due to some
{code}
Should be: "satisfactory compatibility *with* MRv1 applications"

{code}
+  <<mapred>> APIs. This means that applications which were compiled with MRv1
+  <<mapred>> APIs can run directly on YARN without recompilation.
{code}
Should be "This means that applications which were *built against* MRv1 
<<mapred>> APIs"

{code}
+  We cannot ensure complete binary compatibility to the applications that use
{code}
Should be: "binary compatibility *to* the applications"

{code}
+  compatibility. Users are suggested to recompile their applications against
+  MRv2 <<mapreduce>> APIs. One important binary incompatibility break is
{code}
Should be: "Users *should* recompile their applications that *use <<mapreduce>> 
APIs against MRv2 jars*"

{code}
+  Counter and CounterGroup, Users are recommended to recompile their
+  applications if they used the two interfaces. On the other hand, 
<<mapreduce>>
{code}
Probably don't need to recommend a recompile twice.

{code}
+  neither support binary compatibility nor source compatibility to the
+  applications that use this class directly.
{code}
Should be: "compatibility *for* the applications*

{code}
+  Unfortunately, maintaining binary compatibility of <<mapred>> APIs for MRv1
+  applications may lead to binary incompatibility issues for early MRv2
{code}
Should be: "maintaining binary compatibility *with* <<mapred>>"

{code}
+ please note that <<<hadoop -jar hadoop-examples-1.x.x.jar>>> is still using
{code}
Should be: "*will* still use"
                
> Document MR Binary Compatibility vis-a-vis hadoop-1 and hadoop-2
> ----------------------------------------------------------------
>
>                 Key: MAPREDUCE-5184
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5184
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: documentation
>            Reporter: Arun C Murthy
>            Assignee: Zhijie Shen
>             Fix For: 2.1.0-beta
>
>         Attachments: MAPREDUCE-5184.1.patch, MAPREDUCE-5184.2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to