[
https://issues.apache.org/jira/browse/MAPREDUCE-5329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13692293#comment-13692293
]
Avner BenHanoch commented on MAPREDUCE-5329:
--------------------------------------------
got it!
So in general we are talking about a change in *TaskAttemptImpl.java*, in which
we should remove the hard-coded:
{code}
serviceData.put(ShuffleHandler.MAPREDUCE_SHUFFLE_SERVICEID,
ShuffleHandler.serializeServiceData(shuffleToken));
{code}
and replace it with something based on:
{code}
Collection<String> shuffleProviders = conf.getStringCollection(
"mapreduce.shuffle.provider.plugin.classes"); // the constant will come
from mapreduce/MRConfig.java
Collection<String> auxNames = conf.getStringCollection(
YarnConfiguration.NM_AUX_SERVICES);
for (final String serviceName : auxNames) {
try {
String serviceStr = String.format(YarnConfiguration.NM_AUX_SERVICE_FMT,
serviceName);
String serviceClassName = conf.get(serviceStr);
if (shuffleProviders.contains(serviceClassName)) {
LOG.info("Adding " + serviceName + " to serviceData,
serviceClassName=" + serviceClassName);
serviceData.put(serviceName,
ShuffleHandler.serializeServiceData(shuffleToken));
}
} catch (RuntimeException e) {
LOG.error("Failed in " + serviceName+ ", " + serviceClassName, e);
throw e;
}
}
{code}
Is this what you have in mind? Do you see anything else?
> APPLICATION_INIT is never sent to AuxServices other than the builtin
> ShuffleHandler
> -----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-5329
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5329
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mr-am
> Affects Versions: 2.0.4-alpha
> Reporter: Avner BenHanoch
>
> APPLICATION_INIT is never sent to AuxServices other than the built-in
> ShuffleHandler. This means that 3rd party ShuffleProvider(s) will not be
> able to function, because APPLICATION_INIT enables the AuxiliaryService to
> map jobId->userId. This is needed for properly finding the MOFs of a job per
> reducers' requests.
> NOTE: The built-in ShuffleHandler does get APPLICATION_INIT events due to
> hard-coded expression in hadoop code. The current TaskAttemptImpl.java code
> explicitly call: serviceData.put (ShuffleHandler.MAPREDUCE_SHUFFLE_SERVICEID,
> ...) and ignores any additional AuxiliaryService. As a result, only the
> built-in ShuffleHandler will get APPLICATION_INIT events. Any 3rd party
> AuxillaryService will never get APPLICATION_INIT events.
> I think a solution can be in one of two ways:
> 1. Change TaskAttemptImpl.java to loop on all Auxiliary Services and register
> each of them, by calling serviceData.put (…) in loop.
> 2. Change AuxServices.java similar to the fix in: MAPREDUCE-2668
> "APPLICATION_STOP is never sent to AuxServices". This means that in case the
> 'handle' method gets APPLICATION_INIT event it will demultiplex it to all Aux
> Services regardless of the value in event.getServiceID().
> I prefer the 2nd solution. I am welcoming any ideas. I can provide the
> needed patch for any option that people like.
> See [Pluggable Shuffle in Hadoop
> documentation|http://hadoop.apache.org/docs/current/hadoop-mapreduce-client/hadoop-mapreduce-client-core/PluggableShuffleAndPluggableSort.html]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
