[ https://issues.apache.org/jira/browse/MAPREDUCE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698422#comment-13698422 ]
Hudson commented on MAPREDUCE-5359: ----------------------------------- Integrated in Hadoop-trunk-Commit #4037 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4037/]) MAPREDUCE-5359. JobHistory should not use File.separator to match timestamp in path. Contributed by Chuan Liu. (Revision 1499153) Result = SUCCESS cnauroth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1499153 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/jobhistory/JobHistoryUtils.java > JobHistory should not use File.separator to match timestamp in path > ------------------------------------------------------------------- > > Key: MAPREDUCE-5359 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5359 > Project: Hadoop Map/Reduce > Issue Type: Bug > Affects Versions: 3.0.0, 2.1.0-beta > Reporter: Chuan Liu > Assignee: Chuan Liu > Priority: Minor > Attachments: MAPREDUCE-5359-trunk.2.patch, MAPREDUCE-5359-trunk.patch > > > In {{HistoryFileManager.getTimestampPartFromPath()}} method, we use the > following regular expression to match the timestamp in a Path object. > {code:java} > "\\d{4}" + "\\" + File.separator + "\\d{2}" + "\\" + File.separator + > "\\d{2}" > {code} > This is incorrect because Path uses backslash even for Windows path while > File.separator is platform dependent, and is a forward slash on Windows. > This leads to failure matching the timestamp on Windows. One consequence is > that {{addDirectoryToSerialNumberIndex()}} also failed. Later, > {{getFileInfo()}} will fail if the job info is not in cache or intermediate > directory. > The test case {{TestJobHistoryParsing.testScanningOldDirs()}} tests exactly > the above scenario and fails on Windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira