[
https://issues.apache.org/jira/browse/MAPREDUCE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698615#comment-13698615
]
Chris Nauroth commented on MAPREDUCE-5357:
------------------------------------------
{quote}
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}
The patch fixes multiple existing tests, so no new tests are required.
> Job staging directory owner checking could fail on Windows
> ----------------------------------------------------------
>
> Key: MAPREDUCE-5357
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5357
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 3.0.0, 2.1.0-beta
> Reporter: Chuan Liu
> Assignee: Chuan Liu
> Priority: Minor
> Attachments: MAPREDUCE-5357-trunk.patch
>
>
> In {{JobSubmissionFiles.getStagingDir()}}, we have following code that will
> throw exception if the directory owner is not the current user.
> {code:java}
> String owner = fsStatus.getOwner();
> if (!(owner.equals(currentUser) || owner.equals(realUser))) {
> throw new IOException("The ownership on the staging directory " +
> stagingArea + " is not as expected. " +
> "It is owned by " + owner + ". The directory must " +
> "be owned by the submitter " + currentUser + " or " +
> "by " + realUser);
> }
> {code}
> This check will fail on Windows when the underlying file system is
> LocalFileSystem. Because on Windows, the default file or directory owner
> could be "Administrators" group if the user belongs to "Administrators" group.
> Quite a few MR unit tests that runs MR mini cluster with localFs as
> underlying file system fail because of this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira