[
https://issues.apache.org/jira/browse/MAPREDUCE-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719166#comment-13719166
]
Jason Lowe commented on MAPREDUCE-5386:
---------------------------------------
Patch looks pretty good overall. Couple of comments:
* Was there an intent for a more comprehensive test? I see a lot of
refactoring for methods that seem unrelated to this patch otherwise (e.g.:
scanDirectoryForHistoryFilesWrapper, deleteDir, etc.)
* scheduleHistoryCleaner should either always set futureHistoryCleaner (even if
that means setting it to null for no cleaner) or we need to set it to null
after cancelling it.
* Nits: some lines are over 80 columns, arg lists without whitespace between
args, and some methods were added without whitespace between it and the
subsequent method.
> Refresh job retention time,job cleaner interval, enable/disable cleaner
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-5386
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5386
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: jobhistoryserver
> Affects Versions: 2.1.0-beta
> Reporter: Ashwin Shankar
> Assignee: Ashwin Shankar
> Labels: features
> Attachments: JOB_RETENTION-1.txt, JOB_RETENTION-2.txt,
> JOB_RETENTION-3.txt, JOB_RETENTION-4.txt
>
>
> We want to be able to refresh following job retention parameters
> without having to bounce the history server :
> 1. Job retention time - mapreduce.jobhistory.max-age-ms
> 2. Cleaner interval - mapreduce.jobhistory.cleaner.interval-ms
> 3. Enable/disable cleaner -mapreduce.jobhistory.cleaner.enable
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
