[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719649#comment-13719649
 ] 

Tom White commented on MAPREDUCE-5367:
--------------------------------------

I noticed that {{jobDir}} is being assigned to {{LocalJobRunner.SUBDIR}}, i.e. 
"localRunner/" with no job ID, so {{getLocalTaskDir()}} will return a path that 
is not unique for the job. The fix here is to make {{getLocalTaskDir()}} 
non-static. If {{jobDir}} were renamed to {{JOB_BASE_DIR}} then this problem 
would be less likely to be re-introduced in the future.

Also, {{jobDir}} ends in "/", so there is no need to add another path 
separator. It's probably better to use the {{new Path(parent, child)}} 
constructor anyway.
                
> Local jobs all use same local working directory
> -----------------------------------------------
>
>                 Key: MAPREDUCE-5367
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5367
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: MAPREDUCE-5367-b1.patch
>
>
> This means that local jobs, even in different JVMs, can't run concurrently 
> because they might delete each other's files during work directory setup.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to