[
https://issues.apache.org/jira/browse/MAPREDUCE-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773112#comment-13773112
]
Jason Lowe commented on MAPREDUCE-5502:
---------------------------------------
bq. The diff that I pasted does not "appear" correct
To get JIRA to avoid butchering patches, code snippets, and logs, use
\{noformat\} or \{code\} blocks as appropriate. Or even better, attach a patch
to the JIRA and move it to Patch Available so the Jenkins bot can comment.
As for the patch itself, it's a bit odd to be checking the JobStatus.State for
PREP if we're already talking to the AM in the first place. If we got a
successful connection to the AM in order to ask its current state, why not just
send it the kill? All of this is trying to determine whether we can connect to
the AM. If we can connect to it, we should send it a kill. Seems better to
just do the bottom portion of the loop where we try repeatedly to send it a
kill as long as it's not in a terminal state and fallback to the RM if after
repeated attempts it is not in a terminal state.
Also the patch misses one extra status.getState() != JobStatus.State.KILLED
check, and that's within the loop condition. There's no point in looping for
10 seconds trying to kill an application that is in the FAILED or SUCCEEDED
state.
> History link in resource manager is broken for KILLED jobs
> ----------------------------------------------------------
>
> Key: MAPREDUCE-5502
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5502
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.0.5-alpha
> Reporter: Vrushali C
> Assignee: Vrushali C
> Labels: ui
>
> History link in resource manager is broken for KILLED jobs.
> Seems to happen with jobs with State 'KILLED' and FinalStatus 'KILLED'. If
> the State is 'FINISHED' and FinalStatus is 'KILLED', then the "History" link
> is fine.
> It isn't easy to reproduce the problem since the time at which the app is
> killed determines the state it ends up in, which is hard to guess. these
> particular jobs seem to get a Diagnostics message of "Application killed by
> user." where as the other killed jobs get " Kill Job received from client
> job_1378766187901_0002
> Job received Kill while in RUNNING state. "
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
