[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780829#comment-13780829
 ] 

Hudson commented on MAPREDUCE-5529:
-----------------------------------

SUCCESS: Integrated in Hadoop-Hdfs-trunk #1536 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1536/])
MAPREDUCE-5529. Fix compat with hadoop-1 in mapred.TotalOrderPartitioner by 
re-introducing (get,set)PartitionFile which takes in JobConf. Contributed by 
Robert Kanter. (acmurthy: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1527048)
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/TotalOrderPartitioner.java

                
> Binary incompatibilities in mapred.lib.TotalOrderPartitioner between branch-1 
> and branch-2
> ------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5529
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5529
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv1, mrv2
>    Affects Versions: 2.1.1-beta
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>            Priority: Blocker
>             Fix For: 2.1.2-beta
>
>         Attachments: MAPREDUCE-5529_branch_2.patch, MAPREDUCE-5529.patch, 
> MAPREDUCE-5529.patch
>
>
> {{mapred.lib.TotalOrderPartitioner}} in branch-1 has these two methods:
> {code:java}
> public static String getPartitionFile(JobConf job)
> public static void setPartitionFile(JobConf job, Path p)
> {code}
> In branch-2, {{mapred.lib.TotalOrderPartitioner}} is now a subclass of 
> {{mapred.lib.TotalOrderPartitioner}}, from which it inherits the similar 
> methods:
> {code:java}
> public static String getPartitionFile(Configuration conf)
> public static void setPartitionFile(Configuration conf, Path p)
> {code}
> This means that any code that does either of the following:
> {code:java}
> TotalOrderPartitioner.setPartitionFile(new JobConf(), new Path("/"));
> String str = TotalOrderPartitioner.getPartitionFile(new JobConf());
> {code}
> will not be binary compatible (that is, if compiled against branch-1, it will 
> throw a {{NoSuchMethodError}} if run against branch-2).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to