[ https://issues.apache.org/jira/browse/MAPREDUCE-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod Kumar Vavilapalli updated MAPREDUCE-5536: ----------------------------------------------- Status: Open (was: Patch Available) More comments on the patch. This has to be one of the hardest patches I reviewed in recent times. - WebAppUtil.getDefaultJHSWebappPort() and getDefaultJHSWebappURLWithoutScheme() can be private. - getHistoryUrl() -> getApplicationHistoryURLWithoutScheme(). - getJHSWebappURLWithScheme() : No need to have a isSSLEnabledInJHS check. - getJHSSchemePrefix() -> getJHSWebAppSchemePrefix()() - Add a getApplicationHistoryURLWithSchem() and use in MR AM's RMCommunicator? - MR's WebAppUtil -> Mark as Private. - WebAppUtil -> MRWebAppUtil. - JHAdminConfig.getResolvedMRHistoryWebAppURLWithoutScheme() still takes in a flag - it doesn't need to. And may be move it to MiniMRYarnCluster if that is the only caller. I think instead of WebAppUtil.setSSLEnabledIn*() methods, we should have WebAppUtil.initialize(Configuration conf). That way, every component doesn't need to remember what config to read. > mapreduce.jobhistory.webapp.https.address property is not respected > ------------------------------------------------------------------- > > Key: MAPREDUCE-5536 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5536 > Project: Hadoop Map/Reduce > Issue Type: Bug > Affects Versions: 2.1.1-beta > Reporter: Yesha Vora > Assignee: Omkar Vinit Joshi > Priority: Blocker > Attachments: MAPREDUCE-5536.20131027.1.patch, > MAPREDUCE-5536.20131030.1.patch, YARN-1240.20131025.1.patch > > > The jobhistory server starts on port defined by > mapreduce.jobhistory.webapp.address property instead > mapreduce.jobhistory.webapp.https.address when hadoop.ssl.enabled=true. -- This message was sent by Atlassian JIRA (v6.1#6144)