[
https://issues.apache.org/jira/browse/MAPREDUCE-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinod Kumar Vavilapalli updated MAPREDUCE-5562:
-----------------------------------------------
Status: Open (was: Patch Available)
Man, I'll have to get down and rewrite this part of MR AM. Will file a JIRA.
To the point, w.r.t this JIRA, some comments:
- I couldn't quite figure out why the job-end notification is not sent when
unregistration fails. In your patch, this happens only because
StagingDirCleaningService is stopped first, so isLastRetry is reset. Can you
change this to be a little better? Reset isLastRetry when unregister itself
fails - that should make it a bit cleaner.
- AppContext.successfulUnregistered() -> hasSuccessfullyUnregistered()
- AppContext.markSuccessfulUnregistered() -> markSuccessfulUnregistration()
- MRAppMaster.successfulUnregistered -> successfullyUnregistered
- Replace all uses of successfulUnregistered.get() with
context.hasSuccessfullyUnregistered()
> MR AM should exit when unregister() throws exception
> ----------------------------------------------------
>
> Key: MAPREDUCE-5562
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5562
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Zhijie Shen
> Assignee: Zhijie Shen
> Attachments: MAPREDUCE-5562.1.patch, MAPREDUCE-5562.2.patch,
> MAPREDUCE-5562.3.patch, MAPREDUCE-5562.5.patch, MAPREDUCE-5562.6.patch,
> MAPREDUCE-5562.7.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
