[ https://issues.apache.org/jira/browse/MAPREDUCE-5102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788447#comment-13788447 ]
Nathan Roberts commented on MAPREDUCE-5102: ------------------------------------------- Some comments: * In testDBInputFormat - The "second parameter does not work" comment can be removed or reworded. The second parameter is just a hint and does not require the inputformat to follow. * testSplitters - would be nice to also have test cases for NUM_MAPS==2 so that there is more than one split being calculated. * testFloatSplitter - Expected results aren't correct. If minvalue is 5.0 and maxvalue is 7.0, the split should be "column1 >= 5.0, column1 <= 7.0". There is actually a corresponding bug in FloatSplitter (filed MAPREDUCE-5569). > fix coverage org.apache.hadoop.mapreduce.lib.db and > org.apache.hadoop.mapred.lib.db > ------------------------------------------------------------------------------------ > > Key: MAPREDUCE-5102 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5102 > Project: Hadoop Map/Reduce > Issue Type: Test > Affects Versions: 3.0.0, 0.23.7, 2.0.4-alpha > Reporter: Aleksey Gorshkov > Assignee: Andrey Klochkov > Attachments: MAPREDUCE-5102-branch-0.23.patch, > MAPREDUCE-5102-branch-0.23-v1.patch, MAPREDUCE-5102-branch-2--n3.patch, > MAPREDUCE-5102-trunk--n3.patch, MAPREDUCE-5102-trunk.patch, > MAPREDUCE-5102-trunk-v1.patch > > > fix coverage org.apache.hadoop.mapreduce.lib.db and > org.apache.hadoop.mapred.lib.db > patch MAPREDUCE-5102-trunk.patch for trunk and branch-2 > patch MAPREDUCE-5102-branch-0.23.patch for branch-0.23 only -- This message was sent by Atlassian JIRA (v6.1#6144)