[ https://issues.apache.org/jira/browse/MAPREDUCE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788462#comment-13788462 ]
Hadoop QA commented on MAPREDUCE-5569: -------------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12607216/MAPREDUCE-5569-trunk.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4100//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4100//console This message is automatically generated. > FloatSplitter is not generating correct splits > ---------------------------------------------- > > Key: MAPREDUCE-5569 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5569 > Project: Hadoop Map/Reduce > Issue Type: Bug > Affects Versions: trunk, 2.1.0-beta, 1.3.0, 0.23.9 > Reporter: Nathan Roberts > Assignee: Nathan Roberts > Attachments: MAPREDUCE-5569-trunk.patch > > > The closing split is not calculated correctly: > {code} > // Catch any overage and create the closed interval for the last split. > if (curLower <= maxVal || splits.size() == 1) { > splits.add(new DataDrivenDBInputFormat.DataDrivenDBInputSplit( > - lowClausePrefix + Double.toString(curUpper), > + lowClausePrefix + Double.toString(curLower), > colName + " <= " + Double.toString(maxVal))); > } > {code} > For the case of min=5.0, max=7.0, 2 splits, the current code returns splits > of (column1 >=5.0, column1 <6.0), (column1 >=7.0, column1 <=7.0). The second > split is obviously not correct. -- This message was sent by Atlassian JIRA (v6.1#6144)