[
https://issues.apache.org/jira/browse/MAPREDUCE-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802357#comment-13802357
]
Jason Lowe commented on MAPREDUCE-5561:
---------------------------------------
+1, lgtm. It's a reasonable approach.
The test failure is unrelated and most likely caused by something like
YARN-1183. I tested the patch locally and it does not fail. I'll commit this
shortly.
> org.apache.hadoop.mapreduce.v2.app.job.impl.TestJobImpl testcase failing on
> trunk
> ---------------------------------------------------------------------------------
>
> Key: MAPREDUCE-5561
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5561
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 2.2.0
> Reporter: Cindy Li
> Assignee: Karthik Kambatla
> Priority: Critical
> Attachments: mr-5561-1.patch,
> org.apache.hadoop.mapreduce.v2.app.job.impl.TestJobImpl-output.txt
>
>
> Running org.apache.hadoop.mapreduce.v2.app.job.impl.TestJobImpl
> Tests run: 15, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 9.029 sec
> <<< FAILURE! - in org.apache.hadoop.mapreduce.v2.app.job.impl.TestJobImpl
> testFailAbortDoesntHang(org.apache.hadoop.mapreduce.v2.app.job.impl.TestJobImpl)
> Time elapsed: 5.507 sec <<< FAILURE!
> java.lang.AssertionError: expected:<FAIL_ABORT> but was:<FAILED>
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.failNotEquals(Assert.java:647)
> at org.junit.Assert.assertEquals(Assert.java:128)
> at org.junit.Assert.assertEquals(Assert.java:147)
> at
> org.apache.hadoop.mapreduce.v2.app.job.impl.TestJobImpl.assertJobState(TestJobImpl.java:817)
> at
> org.apache.hadoop.mapreduce.v2.app.job.impl.TestJobImpl.testFailAbortDoesntHang(TestJobImpl.java:418)
--
This message was sent by Atlassian JIRA
(v6.1#6144)
