[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13854637#comment-13854637
 ] 

Gera Shegalov commented on MAPREDUCE-5650:
------------------------------------------

[~tomwhite], thanks for reviewing the patch. I added the profile.params 
properties to mapred-default, and fixed my traditional code style mistakes 
regarding whitespace on the second line.

If I understand your interpolation comment correctly, the previous v02 version 
of the patch is already taking care of it. The string relevant for the current 
task attempt is first stored into profileParams and then we call.
{code}
        vargs.add(String.format(profileParams,
            getTaskLogFile(TaskLog.LogName.PROFILE)));
{code}

It's covered by the unit test in the patch. Please elaborate in more detail if 
I am missing something.

> Job fails when hprof mapreduce.task.profile.map/reduce.params is specified
> --------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5650
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5650
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 2.2.0
>            Reporter: Gera Shegalov
>            Assignee: Gera Shegalov
>         Attachments: MAPREDUCE-5650.v01.patch, MAPREDUCE-5650.v02.patch, 
> MAPREDUCE-5650.v03.patch
>
>
> When one uses dedicated hprof mapreduce.task.profile.map.params or 
> mapreduce.task.profile.reduce.params, the profiled tasks will fail to launch 
> because hprof parameters are supplied to the child jvm twice.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to