[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915945#comment-13915945
 ] 

Hadoop QA commented on MAPREDUCE-5264:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12586811/MAPREDUCE-5264.20130607.1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4386//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4386//console

This message is automatically generated.

> FileAlreadyExistsException is assumed to be thrown by FileSystem#mkdirs or 
> FileContext#mkdir in the codebase
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5264
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5264
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: Rémy SAISSY
>         Attachments: MAPREDUCE-5264.20130607.1.patch
>
>
> According to https://issues.apache.org/jira/browse/HADOOP-9438,
> FileSystem#mkdirs and FileContext#mkdir do not throw 
> FileAlreadyExistsException if the directory already exist.
> Some places in the mapreduce codebase assumes FileSystem#mkdirs or 
> FileContext#mkdir throw FileAlreadyExistsException.
> At least the following files are concerned:
>  - YarnChild.java
>  - JobHistoryEverntHandler.java
>  - HistoryFileManager.java
> It would be good to re-review and patch this if needed.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to