[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Lowe updated MAPREDUCE-4941:
----------------------------------

    Resolution: Won't Fix
        Status: Resolved  (was: Patch Available)

Given MAPREDUCE-5273 added back in rrClass and others for backwards 
compatibility, I'm worried that fixing this could create a source 
incompatibility for those that assumed they could copy the rrClass member to 
another {{Class<RecordReader<K,V>}} variable.

Given how minor this is and the fact that it's not always required to do the 
cast (see org.apache.hadoop.mapred.lib.CombineTextInputFormat for one example), 
I don't think this is worth fixing at this point given the potential for 
breaking backwards compatibility.

> Use of org.apache.hadoop.mapred.lib.CombineFileRecordReader requires casting
> ----------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4941
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4941
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 2.0.2-alpha, 0.23.5
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>            Priority: Minor
>         Attachments: MAPREDUCE-4941.patch, MAPREDUCE-4941.patch
>
>
> Unlike its counterpart in org.apache.hadoop.mapreduce.lib.input, the 
> CombineFileRecordReader in mapred requires a user to cast to a RecordReader 
> since the constructor specification says it must have the RecordReader<K,V> 
> class as a parameter.  It should use {{Class<? extends RecordReader<K,V>>}} 
> like its mapreduce counterpart to make it easier to use.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to