[ https://issues.apache.org/jira/browse/MAPREDUCE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969867#comment-13969867 ]
Chris Nauroth commented on MAPREDUCE-5833: ------------------------------------------ Hi, [~zjshen]. Thanks for fixing this. For draining the event queue, could you please use {{GenericTestUtils#waitFor}}? Right now, if we had a bug such that the event queue wasn't getting fully drained, then this test would go into an infinite loop. If instead we use {{GenericTestUtils#waitFor}}, then the test will fail after some maximum wait time and give us a thread dump to help with diagnosis. > TestRMContainerAllocator fails ocassionally > ------------------------------------------- > > Key: MAPREDUCE-5833 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5833 > Project: Hadoop Map/Reduce > Issue Type: Bug > Reporter: Zhijie Shen > Assignee: Zhijie Shen > Attachments: MAPREDUCE-5833.1.patch > > > testReportedAppProgress and testReportedAppProgressWithOnlyMaps have race > conditions. > {code} > Stacktrace > java.util.NoSuchElementException: null > at java.util.Collections$EmptyIterator.next(Collections.java:2998) > at > org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator.testReportedAppProgress(TestRMContainerAllocator.java:535) > {code} > {code} > Error Message > Task state is not correct (timedout) expected:<RUNNING> but was:<SCHEDULED> > Stacktrace > junit.framework.AssertionFailedError: Task state is not correct (timedout) > expected:<RUNNING> but was:<SCHEDULED> > at junit.framework.Assert.fail(Assert.java:50) > at junit.framework.Assert.failNotEquals(Assert.java:287) > at junit.framework.Assert.assertEquals(Assert.java:67) > at org.apache.hadoop.mapreduce.v2.app.MRApp.waitForState(MRApp.java:393) > at > org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator.testReportedAppProgressWithOnlyMaps(TestRMContainerAllocator.java:700) > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)