[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996830#comment-13996830
 ] 

Chris Nauroth commented on MAPREDUCE-5886:
------------------------------------------

Hi, [~jira.shegalov] and [~ajisakaa].  Thanks for looking at this and 
contributing some new ideas.

Regarding {{FileInputFormat#addInputPaths}}, in addition to the issue raised by 
Akira for supporting comma in a file name, there is another reason why I didn't 
use that method.  On Windows Command Prompt, the comma acts as an argument 
separator, much like space.  This would have the potential to create confusion 
for users on Windows.

The basic concept of the new API looks good to me.  We might instead consider 
passing varargs and no range indices.  Word count could chop the input args 
down to the correct range using {{Arrays#copyOfRange}} or {{List#subList}}.

Would you mind moving all of the API work to another jira?  MAPREDUCE-5889 
probably would work for that.  For this issue, I was hoping to put in a quick 
trivial patch in just word count to enable this.  IOW, I'd like to pursue a 
binding +1 on patch v1 and commit it.

Thanks again!

> Allow wordcount example job to accept multiple input paths.
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-5886
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5886
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: examples
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Minor
>         Attachments: MAPREDUCE-5886.1.patch, MAPREDUCE-5886.2.patch, 
> MAPREDUCE-5886.3.patch
>
>
> It would be convenient if the wordcount example MapReduce job could accept 
> multiple input paths and run the word count on all of them.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to