[ https://issues.apache.org/jira/browse/MAPREDUCE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997833#comment-13997833 ]
Tsuyoshi OZAWA commented on MAPREDUCE-5861: ------------------------------------------- Thank you for the review, Sangjin and Junping! > finishedSubMaps field in LocalContainerLauncher does not need to be volatile > ---------------------------------------------------------------------------- > > Key: MAPREDUCE-5861 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5861 > Project: Hadoop Map/Reduce > Issue Type: Bug > Reporter: Ted Yu > Assignee: Tsuyoshi OZAWA > Priority: Minor > Attachments: MAPREDUCE-5861.1.patch, MAPREDUCE-5861.2.patch > > > Around line 374: > {code} > if (++finishedSubMaps == numMapTasks) { > doneWithMaps = true; > } > {code} > The increment of finishedSubMaps is not atomic. > See the answer to > http://stackoverflow.com/questions/9749746/what-is-the-difference-of-atomic-volatile-synchronize > . > AtomicInteger can be used to achieve atomicity. -- This message was sent by Atlassian JIRA (v6.2#6252)