[
https://issues.apache.org/jira/browse/MAPREDUCE-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010684#comment-14010684
]
Akira AJISAKA commented on MAPREDUCE-5889:
------------------------------------------
Thanks [~ozawa] for the comments.
bq. Could you explain why you add the annotation to
{{createValueAggregatorJob}} and {{getConf}}?
I added the annotation to the v2 patch because the variable string can be
comma-separated in the methods.
bq. It can be good mark to refactor.
You are right. Refactored the code not to use the deprecated methods.
bq. How about adding tests against addInputPaths(Job, Path...)?
Added {{o.a.h.mapreduce.lib.input.TestInputPath}} for testing.
bq. If we add {{addInputPaths(Job job, Path... inputPaths)}}, why don't you
call it in {{addInputPaths(Job, String)}} like {{setInputPaths(Job, String)}}?
Reflected in the v3 patch.
bq. Should we change not only
{{org.apache.hadoop.mapreduce.lib.input.FileInputFormat}} but also
{{org.apache.hadoop.mapred.FileInputFormat}}?
Reflected in the v3 patch.
> Deprecate FileInputFormat.setInputPaths(Job, String) and
> FileInputFormat.addInputPaths(Job, String)
> ---------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-5889
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5889
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Akira AJISAKA
> Assignee: Akira AJISAKA
> Priority: Minor
> Labels: newbie
> Attachments: MAPREDUCE-5889.3.patch, MAPREDUCE-5889.patch,
> MAPREDUCE-5889.patch
>
>
> {{FileInputFormat.setInputPaths(Job job, String commaSeparatedPaths)}} and
> {{FileInputFormat.addInputPaths(Job job, String commaSeparatedPaths)}} fail
> to parse commaSeparatedPaths if a comma is included in the file path. (e.g.
> Path: {{/path/file,with,comma}})
> We should deprecate these methods and document to use {{setInputPaths(Job
> job, Path... inputPaths)}} and {{addInputPaths(Job job, Path... inputPaths)}}
> instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
