[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011172#comment-14011172
 ] 

Uma Maheswara Rao G commented on MAPREDUCE-5898:
------------------------------------------------

Thanks a lot Yi for the patch.
I have few comments below.

DistCpUtils.java:
  file system rooot. ---> file system root.

 {code}
  try {
      fs.getXAttrs(new Path(Path.SEPARATOR));
    } catch (Exception e) {
      throw new XAttrsNotSupportedException("XAttrs not supported for file 
system: "
        + fs.getUri());
    }
  {code}
  seems like we are generically handling Exception and saying xattrs not 
supported in fs. But the api call can fail due to many other reasons like 
permission issues. Does it possible to bring down to handle specific 
exception?ex: no such method etc.

  {code}
  new Option("p", true, "preserve status (rbugpca)(replication, " +
  {code}
  we need to change from rbugpca -> rbugpcax?

> distcp to support preserving HDFS extended attributes(XAttrs)
> -------------------------------------------------------------
>
>                 Key: MAPREDUCE-5898
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5898
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: distcp
>    Affects Versions: 3.0.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Yi Liu
>         Attachments: MAPREDUCE-5898.patch
>
>
> This JIRA to track the distcp support to handle the Xattrs with preserving 
> options.
> Add new command line argument to support that.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to