[
https://issues.apache.org/jira/browse/MAPREDUCE-424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allen Wittenauer resolved MAPREDUCE-424.
----------------------------------------
Resolution: Incomplete
I suspect this is stale.
> Unreachable code in TaskInProgress.inCompleteSubTask
> ----------------------------------------------------
>
> Key: MAPREDUCE-424
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-424
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Attachments: patch-5236-1.txt, patch-5236.txt
>
>
> TaskInProgress.incompleteSubTask has the following unreachable-code :
> {noformat}
> if (taskState != TaskStatus.State.FAILED &&
> taskState != TaskStatus.State.KILLED &&
> taskState != TaskStatus.State.FAILED_UNCLEAN &&
> taskState != TaskStatus.State.KILLED_UNCLEAN) {
> LOG.info("Task '" + taskid + "' running on '" + trackerName +
> "' in state: '" + taskState + "' being failed!");
> status.setRunState(TaskStatus.State.FAILED);
> taskState = TaskStatus.State.FAILED;
> }
> {noformat}
> It would never reach this code, because it is never called from other places,
> where taskState is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
> Also status != null is not required, since status is never null.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
