[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096748#comment-14096748
 ] 

Manu Zhang commented on MAPREDUCE-5977:
---------------------------------------

Thanks for the comment.

1. Just wrote a performance test on WritableUtils:writeFloat, where I wrote out 
a float for 10M times. I didn't find any difference w/ and w/o strict-aliasing 
flag. Also checked about other native perf tests and no impact of 
-fno-strict-aliasing was found. 
2. oh,  I was too happy removing unused codes. I will use assertion.
3. your trick looks fine. 

will upload a new patch soon   

> Fix or suppress native-task gcc warnings
> ----------------------------------------
>
>                 Key: MAPREDUCE-5977
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: task
>            Reporter: Todd Lipcon
>            Assignee: Manu Zhang
>         Attachments: gcc_compile.log, mapreduce-5977-v2.txt, 
> mapreduce-5977.txt
>
>
> Currently, building the native task code on gcc 4.8 has a fair number of 
> warnings. We should fix or suppress them so that new warnings are easier to 
> see.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to