[
https://issues.apache.org/jira/browse/MAPREDUCE-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102690#comment-14102690
]
Hadoop QA commented on MAPREDUCE-5860:
--------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12662748/MAPREDUCE-5860.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4810//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4810//console
This message is automatically generated.
> Hadoop pipes Combiner is closed before all of its reduce calls
> --------------------------------------------------------------
>
> Key: MAPREDUCE-5860
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5860
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: pipes
> Affects Versions: 0.23.0, trunk
> Environment: 0.23.0 on 64 bit linux
> Reporter: Joe Mudd
> Fix For: trunk
>
> Attachments: MAPREDUCE-5860.patch
>
>
> When a Combiner is specified to runTask() its reduce() method may be called
> after its close() method has been called due to how the Combiner's containing
> object, CombineRunner, is closed after the TaskContextImpl's reducer member
> is closed (see TaskContextImpl::closeAll()).
> I believe the fix is to delegate the Combiner's ownership to CombineRunner,
> making it responsible for calling the Combiner's close() method and deleting
> the Combiner instance.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
