[
https://issues.apache.org/jira/browse/MAPREDUCE-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Lipcon updated MAPREDUCE-6069:
-----------------------------------
Attachment: mr-6069.txt
Attached patch removes a bunch of dead code. I built the C++ code with a
coverage tool and then looked at which sections of code were never run and
found a lot of dead utility code, and code which was meant for the more generic
"native task" framework and not the "native collector" framework. Although that
code might be useful if we some day want to allow user-defined C++
mapper/reducer/etc, we can always resurrect it from git history at that point.
Given that the code is not currently within the scope of the project, I think
it's best to remove it to avoid confusion.
Enumerated changes:
* Remove SpinLock, Condition Variable and Thread wrappers from SyncUtils
(unused)
* Remove unused TrackingCollector
* Reformat code to not go over 100 columns except in rare cases
* Fix up a lot of whitespace/indentation errors (using cpplint.py)
* Remove empty JavaDoc @param/@return annotations
* Remove some blocks of commented-out code
* Remove DynamicBuffer (unused)
* Remove support for native combiners
(Java-side support was already removed, not covered by any tests)
* Remove object factory support and interfaces for for native
implementations
of Partitioner, Input/Output formats, etc (dead code)
* Remove cityhash and wrapper (unused)
* Remove BufferedInputStream/BufferedOutputStream
> native-task: Style fixups and dead code removal
> -----------------------------------------------
>
> Key: MAPREDUCE-6069
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6069
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: task
> Reporter: Todd Lipcon
> Attachments: mr-6069.txt
>
>
> A few more cleanup things we should address:
> - fix style issues (eg lines too long, bad indentation, commented-out code
> blocks, etc) both in Java and C++
> - Found a few pieces of unused code by running a coverage tool. We should
> remove them
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
