[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140810#comment-14140810
 ] 

Jason Lowe commented on MAPREDUCE-6095:
---------------------------------------

Thanks for the report and patch, Gera!  Patch looks good overall, just some 
minor nits:

- adding "local" to the method name (e.g.: setupDistributedCacheLocalConfig) 
would make it a bit clearer what the method is doing and when it should be 
called
- it'd be nice if the method was located in the file near the other methods 
related to the distributed cache for more coherency when browsing the file
- The JobConf import that was added is not needed (actually there are a number 
of unused imports in MRApps that would be nice to clean up).

> Enable DistributedCache for uber-mode Jobs
> ------------------------------------------
>
>                 Key: MAPREDUCE-6095
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6095
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: applicationmaster, distributed-cache
>    Affects Versions: 2.0.5-alpha
>            Reporter: Gera Shegalov
>            Assignee: Gera Shegalov
>         Attachments: MAPREDUCE-6095.v01.patch
>
>
> mapreduce.job.cache.local.* is not set for uber-mode jobs. TestUberAM hides 
> the fact that DC files are not available for uber-mode jobs by overriding 
> testDistributedCache with a nop method. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to