[
https://issues.apache.org/jira/browse/MAPREDUCE-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209019#comment-14209019
]
Hadoop QA commented on MAPREDUCE-6156:
--------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12681186/MAPREDUCE-6156-v2.patch
against trunk revision d7150a1.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5015//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5015//console
This message is automatically generated.
> Fetcher - connect() doesn't handle connection refused correctly
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-6156
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6156
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Sidharta Seethana
> Assignee: Junping Du
> Priority: Blocker
> Attachments: MAPREDUCE-6156-v2.patch, MAPREDUCE-6156.patch
>
>
> The connect() function in the fetcher assumes that whenever an IOException is
> thrown, the amount of time passed equals "connectionTimeout" ( see code
> snippet below ). This is incorrect. For example, in case the NM is down, an
> ConnectException is thrown immediately - and the catch block assumes a minute
> has passed when it is not the case.
> {code}
> if (connectionTimeout < 0) {
> throw new IOException("Invalid timeout "
> + "[timeout = " + connectionTimeout + " ms]");
> } else if (connectionTimeout > 0) {
> unit = Math.min(UNIT_CONNECT_TIMEOUT, connectionTimeout);
> }
> // set the connect timeout to the unit-connect-timeout
> connection.setConnectTimeout(unit);
> while (true) {
> try {
> connection.connect();
> break;
> } catch (IOException ioe) {
> // update the total remaining connect-timeout
> connectionTimeout -= unit;
> // throw an exception if we have waited for timeout amount of time
> // note that the updated value if timeout is used here
> if (connectionTimeout == 0) {
> throw ioe;
> }
> // reset the connect timeout for the last try
> if (connectionTimeout < unit) {
> unit = connectionTimeout;
> // reset the connect time out for the final connect
> connection.setConnectTimeout(unit);
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
