[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321770#comment-14321770
 ] 

Tsuyoshi OZAWA commented on MAPREDUCE-6256:
-------------------------------------------

+1. I think these variables and methods can be removed safely since these are 
"private". Committing the patch shortly.

{quote}
As DistributedCache class itself is deprecated (MAPREDUCE-5623), do we need to 
mark all the below public methods deprecated ?
All the methods in o.a.h.mapreduce.Job.java which were only accessing 
DistributedCache, do we need to mark it also deprecated ?
{quote}

I think we shouldn't change them for 2.x to keep backward compatibility as you 
mentioned e.g. Hive UDF can access these methods(HIVE-1016). Could you open new 
JIRA to discuss that?

> Removed unused private methods in o.a.h.mapreduce.Job.java
> ----------------------------------------------------------
>
>                 Key: MAPREDUCE-6256
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6256
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Devaraj K
>            Assignee: Naganarasimha G R
>            Priority: Minor
>              Labels: newbie
>         Attachments: MAPREDUCE-6256.20150214-1.patch
>
>
> These below methods are not used any where in the code and these can be 
> removed.
> {code:xml}
>   private void setStatus(JobStatus status)
>   private boolean shouldDownloadProfile()
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to