[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339023#comment-14339023
 ] 

Hadoop QA commented on MAPREDUCE-6267:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12701144/MAPREDUCE-6267-trunk-v1.patch
  against trunk revision dce8b9c.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

Test results: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5226//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5226//console

This message is automatically generated.

> Refactor JobSubmitter#copyAndConfigureFiles into it's own class
> ---------------------------------------------------------------
>
>                 Key: MAPREDUCE-6267
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6267
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Chris Trezzo
>            Assignee: Chris Trezzo
>            Priority: Minor
>         Attachments: MAPREDUCE-6267-trunk-v1.patch
>
>
> Refactor the uploading logic in JobSubmitter#copyAndConfigureFiles into it's 
> own class. This makes the JobSubmitter class more readable and isolates the 
> logic that is actually uploading the job resources to HDFS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to