[ https://issues.apache.org/jira/browse/MAPREDUCE-6265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359899#comment-14359899 ]
Hadoop QA commented on MAPREDUCE-6265: -------------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704343/MAPREDUCE-6265.000.patch against trunk revision 8212877. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5285//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5285//console This message is automatically generated. > make INITIAL_POOL_SIZE in ContainerLauncherImpl configurable to better > control the thread pool size to launch/kill containers. > ------------------------------------------------------------------------------------------------------------------------------ > > Key: MAPREDUCE-6265 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6265 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv2 > Reporter: zhihai xu > Assignee: zhihai xu > Attachments: MAPREDUCE-6265.000.patch > > > make INITIAL_POOL_SIZE in ContainerLauncherImpl configurable to better > control the thread pool size to launch/kill containers > Currently INITIAL_POOL_SIZE in ContainerLauncherImpl is hard-coded at > {code} > protected static final int INITIAL_POOL_SIZE = 10; > {code} > We should make it configurable because the thread pool size will be decided > by INITIAL_POOL_SIZE, limitOnPoolSize and number of node used by the AM. > Since we already made limitOnPoolSize configurable, it make senses to also > make INITIAL_POOL_SIZE configurable to better manage the thread pool size. > We saw some issue due to the small thread pool size when some node is down. > The recovery from a shutdown node take very long time due to all the > ContainerLauncher threads are blocked by IPC client connection to the > shutdown node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)