[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14364624#comment-14364624
 ] 

Harsh J commented on MAPREDUCE-5733:
------------------------------------

Attached diff is invalid (it seems to be a diff of /dev/null and the patch, 
i.e. a diff of the diff). Please submit a new patch.

> (Configugration) conf.set("textinputformat.record.delimiter","myDelimiter") , 
> is bound to typo error. Lets have it as a Static String in some class, to 
> minimise such error. This would also help in IDE like eclipse suggesting the 
> String.
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5733
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5733
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Gelesh
>            Assignee: Abhilash S R
>            Priority: Trivial
>         Attachments: MAPREDUCE-5733.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> (Configugration) conf.set("textinputformat.record.delimiter","myDelimiter") , 
> is bound to typo error. Lets have it as a Static String in some class, to 
> minimise such error. This would also help in IDE like eclipse suggesting the 
> String.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to