[ https://issues.apache.org/jira/browse/MAPREDUCE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370965#comment-14370965 ]
Akira AJISAKA commented on MAPREDUCE-6165: ------------------------------------------ bq. Why not using assertEquals(2, splits.size())? split.size() can be 1 or 2. The size depends on the ordering. bq. I think some applications depend on the ordering...maybe it would be good to use TreeMap<K,V> or LinkedHashMap<K, V> instead of HashMap. I'm thinking using TreeMap or LinkedHashMap fixes the test but it's useless for production. > [JDK8] TestCombineFileInputFormat failed on JDK8 > ------------------------------------------------ > > Key: MAPREDUCE-6165 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6165 > Project: Hadoop Map/Reduce > Issue Type: Bug > Reporter: Wei Yan > Assignee: Akira AJISAKA > Priority: Minor > Attachments: MAPREDUCE-6165-001.patch, MAPREDUCE-6165-reproduce.patch > > > The error msg: > {noformat} > testSplitPlacementForCompressedFiles(org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat) > Time elapsed: 2.487 sec <<< FAILURE! > junit.framework.AssertionFailedError: expected:<2> but was:<1> > at junit.framework.Assert.fail(Assert.java:57) > at junit.framework.Assert.failNotEquals(Assert.java:329) > at junit.framework.Assert.assertEquals(Assert.java:78) > at junit.framework.Assert.assertEquals(Assert.java:234) > at junit.framework.Assert.assertEquals(Assert.java:241) > at junit.framework.TestCase.assertEquals(TestCase.java:409) > at > org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat.testSplitPlacementForCompressedFiles(TestCombineFileInputFormat.java:911) > testSplitPlacement(org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat) > Time elapsed: 0.985 sec <<< FAILURE! > junit.framework.AssertionFailedError: expected:<2> but was:<1> > at junit.framework.Assert.fail(Assert.java:57) > at junit.framework.Assert.failNotEquals(Assert.java:329) > at junit.framework.Assert.assertEquals(Assert.java:78) > at junit.framework.Assert.assertEquals(Assert.java:234) > at junit.framework.Assert.assertEquals(Assert.java:241) > at junit.framework.TestCase.assertEquals(TestCase.java:409) > at > org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat.testSplitPlacement(TestCombineFileInputFormat.java:368) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)