[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14374960#comment-14374960
 ] 

Hudson commented on MAPREDUCE-6286:
-----------------------------------

FAILURE: Integrated in Hadoop-Hdfs-trunk #2072 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2072/])
MAPREDUCE-6286. A typo in HistoryViewer makes some code useless, which causes 
counter limits are not reset correctly. Contributed by Zhihai Xu. (harsh: rev 
433542904aba5ddebf9bd9d299378647351eb13a)
* hadoop-mapreduce-project/CHANGES.txt
* 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java
MAPREDUCE-6286. Amend commit to CHANGES.txt for backport into 2.7.0. (harsh: 
rev 8770c82acc948bc5127afb1c59072718fd04630c)
* hadoop-mapreduce-project/CHANGES.txt


> A typo in HistoryViewer makes some code useless, which causes counter limits 
> are not reset correctly.
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6286
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6286
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 2.6.0
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>             Fix For: 2.7.0
>
>         Attachments: MAPREDUCE-6286.000.patch
>
>
> A typo in HistoryViewer makes some code useless and it causes counter limits 
> are not reset correctly.
> The typo is
> Limits.reset(conf);
> We should use jobConf instead of conf.
> With the typo, the following code becomes useless:
> {code}
>       final Path jobConfPath = new Path(jobFile.getParent(),  jobDetails[0]
>           + "_" + jobDetails[1] + "_" + jobDetails[2] + "_conf.xml");
>       final Configuration jobConf = new Configuration(conf);
>         jobConf.addResource(fs.open(jobConfPath), jobConfPath.toString());
> {code}
> The code wants to load the configuration from the Job configuration file and 
> reset the Limits based on the new configuration loaded from the Job 
> configuration file. But with the typo, the Limits are reset with the old 
> configuration.
> So this typo is apparent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to