[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507940#comment-14507940
 ] 

Jason Lowe commented on MAPREDUCE-6279:
---------------------------------------

Thanks for picking this up, Eric!  Sorry for the long delay.

bq.  are unit tests necessary for this change?

It would be nice to add a unit test to verify we try to exit during normal 
operations.  It should be relatively straightforward to add one to 
TestMRAppMaster, as ExitUtil has convenience functions for determining if it 
was called and if so with what exception.  If it ends up being too complicated 
then don't bother, but at a glance it appears it would be easy to add.

> AM should explicity exit JVM after all services have stopped
> ------------------------------------------------------------
>
>                 Key: MAPREDUCE-6279
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6279
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 2.5.0
>            Reporter: Jason Lowe
>            Assignee: Eric Payne
>         Attachments: MAPREDUCE-6279.v1.txt
>
>
> Occasionally the MapReduce AM can "get stuck" trying to shut down.  
> MAPREDUCE-6049 and MAPREDUCE-5888 were specific instances that have been 
> fixed, but this can also occur with uber jobs if the task code inadvertently 
> leaves non-daemon threads lingering.
> We should explicitly shutdown the JVM after the MapReduce AM has unregistered 
> and all services have been stopped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to