[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525664#comment-14525664
 ] 

Hadoop QA commented on MAPREDUCE-5954:
--------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 33s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 1 new or modified test files. |
| {color:green}+1{color} | javac |   7m 31s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 36s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   1m 16s | The applied patch generated  3 
new checkstyle issues (total was 15, now 18). |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 6  line(s) that 
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   2m 36s | The patch does not introduce 
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | mapreduce tests |   8m 58s | Tests passed in 
hadoop-mapreduce-client-app. |
| {color:green}+1{color} | mapreduce tests |   0m 46s | Tests passed in 
hadoop-mapreduce-client-common. |
| {color:green}+1{color} | mapreduce tests | 105m 56s | Tests passed in 
hadoop-mapreduce-client-jobclient. |
| | | 153m 53s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12654187/MAPREDUCE-5954.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / e8d0ee5 |
| checkstyle |  
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5617/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-common.txt
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5617/artifact/patchprocess/whitespace.txt
 |
| hadoop-mapreduce-client-app test log | 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5617/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
 |
| hadoop-mapreduce-client-common test log | 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5617/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt
 |
| hadoop-mapreduce-client-jobclient test log | 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5617/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5617/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5617/console |


This message was automatically generated.

> Optional exclusion of counters from getTaskReports
> --------------------------------------------------
>
>                 Key: MAPREDUCE-5954
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5954
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Maysam Yabandeh
>            Assignee: Maysam Yabandeh
>         Attachments: MAPREDUCE-5954.patch
>
>
> MRClientService#getTaskReports returns the set of map or reduce tasks along 
> with their counters, which are quite large. For big jobs, the response could 
> be as large as 0.5 GB. This has a negative impact both on MRAppMaster and the 
> monitoring tool that invokes getTaskReports. This problem has led Pig users 
> to entirely disable getTaskReports for big jobs:
> https://issues.apache.org/jira/browse/PIG-4043
> Many monitoring tools, including ours, do not need the task counters when 
> invoking getTaskReports. Pig also does not make any use of task counters. 
> Here are the usages of Tasks in pig:
> {code}
>     protected void getErrorMessages(TaskReport reports[], String type,
>             String msgs[] = reports[i].getDiagnostics();
>                 if (HadoopShims.isJobFailed(reports[i])) {
> {code}
> and
> {code}
>     protected long computeTimeSpent(TaskReport[] taskReports) {
>         long timeSpent = 0;
>         for (TaskReport r : taskReports) {
>             timeSpent += (r.getFinishTime() - r.getStartTime());
>         }
>         return timeSpent;
>     }
> {code}
> GetTaskReportsRequest can be augmented with an optional boolean with which 
> the monitoring tool can request excluding the counters form the response. 
> This minor change is very simple and yet makes many existing monitoring tools 
> more efficient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to