[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534615#comment-14534615
 ] 

Hadoop QA commented on MAPREDUCE-5981:
--------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 32s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | javac |   7m 30s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 36s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 48s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 14s | The patch does not introduce 
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | mapreduce tests |   1m 35s | Tests passed in 
hadoop-mapreduce-client-core. |
| | |  37m 49s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12731427/MAPREDUCE-5981.02.patch
 |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 9757864 |
| hadoop-mapreduce-client-core test log | 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5673/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5673/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5673/console |


This message was automatically generated.

> Log levels of certain MR logs can be changed to DEBUG
> -----------------------------------------------------
>
>                 Key: MAPREDUCE-5981
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5981
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 2.7.0
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: BB2015-05-RFC
>         Attachments: MAPREDUCE-5981.02.patch, MAPREDUCE-5981.patch
>
>
> Following map reduce logs can be changed to DEBUG log level as they appear 
> too many times in the log file and are not that important for debugging.
> 1. In 
> org.apache.hadoop.mapreduce.task.reduce.Fetcher#copyFromHost(Fetcher.java : 
> 313), the second log is not required to be at info level. This can be moved 
> to debug as a warn log is anyways printed if verifyReply fails.
>       SecureShuffleUtils.verifyReply(replyHash, encHash, shuffleSecretKey);
>       LOG.info("for url="+msgToEncode+" sent hash and received reply");
> 2. Thread related info need not be printed in logs at INFO level. Below 2 
> logs can be moved to DEBUG
>     a) In 
> org.apache.hadoop.mapreduce.task.reduce.ShuffleSchedulerImpl#getHost(ShuffleSchedulerImpl.java
>  : 381), below log can be changed to DEBUG
>    LOG.info("Assigning " + host + " with " + host.getNumKnownMapOutputs() +
>                " to " + Thread.currentThread().getName());
>     b) In 
> org.apache.hadoop.mapreduce.task.reduce.ShuffleScheduler.getMapsForHost(ShuffleSchedulerImpl.java
>  : 411), below log can be changed to DEBUG
>  LOG.info("assigned " + includedMaps + " of " + totalSize + " to " +
>              host + " to " + Thread.currentThread().getName());
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to