[ https://issues.apache.org/jira/browse/MAPREDUCE-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536282#comment-14536282 ]
Hadoop QA commented on MAPREDUCE-5876: -------------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 37s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 7m 29s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 34s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 1m 20s | There were no new checkstyle issues. | | {color:red}-1{color} | whitespace | 0m 0s | The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 36s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 56s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:green}+1{color} | mapreduce tests | 1m 36s | Tests passed in hadoop-mapreduce-client-core. | | {color:green}+1{color} | mapreduce tests | 107m 29s | Tests passed in hadoop-mapreduce-client-jobclient. | | | | 146m 36s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12643448/MAPREDUCE-5876.1.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 6471d18 | | whitespace | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5693/artifact/patchprocess/whitespace.txt | | hadoop-mapreduce-client-core test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5693/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt | | hadoop-mapreduce-client-jobclient test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5693/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt | | Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5693/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5693/console | This message was automatically generated. > SequenceFileRecordReader NPE if close() is called before initialize() > --------------------------------------------------------------------- > > Key: MAPREDUCE-5876 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5876 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client > Affects Versions: 2.3.0, 2.4.0 > Reporter: Reinis Vicups > Assignee: Tsuyoshi Ozawa > Labels: BB2015-05-RFC > Attachments: MAPREDUCE-5876.1.patch > > > org.apache.hadoop.mapreduce.lib.input.SequenceFileRecordReader extends > org.apache.hadoop.mapreduce.RecordReader which in turn implements > java.io.Closeable. > According to java spec the java.io.Closeable#close() has to be idempotent > (http://docs.oracle.com/javase/7/docs/api/java/io/Closeable.html) which is > not. > An NPE is being thrown if close() method is invoked without previously > calling initialize() method. This happens because SequenceFile.Reader in is > null. -- This message was sent by Atlassian JIRA (v6.3.4#6332)