[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537612#comment-14537612
 ] 

Tsuyoshi Ozawa commented on MAPREDUCE-6298:
-------------------------------------------

The fix itself looks good to me. 

[~jira.shegalov] I'd like to to listen to your opinion - do you think should we 
mark this change as incompatible change? It change the semantics of 
Job#toString, but current users don't call toString in not running state.

> Job#toString throws an exception when not in state RUNNING
> ----------------------------------------------------------
>
>                 Key: MAPREDUCE-6298
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6298
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>              Labels: BB2015-05-TBR
>         Attachments: MAPREDUCE-6298.1.patch
>
>
> Job#toString calls {{ensureState(JobState.RUNNING);}} as the very first 
> thing. That method causes an Exception to be thrown which is not nice.
> One thing this breaks is usage of Job on the Scala (e.g. Spark) REPL as that 
> calls toString after every invocation and that fails every time.
> I'll attach a patch that checks state and if it's RUNNING prints the original 
> message and if not prints something else.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to