[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576615#comment-14576615
 ] 

Devaraj K commented on MAPREDUCE-6350:
--------------------------------------

Thanks [~l201514] for the updated patch.

1. Can you address the checkstyle reported by jenkins? You need to add the 
period at the end of the inline comment.

{code:xml}
+   * Number of characters allowed for job name in Job History Server web page
{code}

2. Please add the new configuration in mapred-default.xml under 'jobhistory 
properties'.

3. Can you change the constant names JOB_NAME_TRIM_LENGTH & 
JOB_NAME_TRIM_LENGTH_DEFAULT  according to the configuration like 
MR_HS_JOBNAME_LIMIT & DEFAULT_MR_HS_JOBNAME_LIMIT  as show below. And also for 
the config value, make use of the MR_HISTORY_PREFIX.

{code:xml}
  /**
   * Number of characters allowed for job name in Job History Server web page.
   */
  public static final String MR_HS_JOBNAME_LIMIT = MR_HISTORY_PREFIX
      + "jobname.limit";
  public static final int DEFAULT_MR_HS_JOBNAME_LIMIT = 50;
{code}

> JobHistory doesn't support fully-functional search
> --------------------------------------------------
>
>                 Key: MAPREDUCE-6350
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6350
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobhistoryserver
>            Reporter: Siqi Li
>            Assignee: Siqi Li
>            Priority: Critical
>         Attachments: MAPREDUCE-6350.v1.patch, YARN-1614.v1.patch, 
> YARN-1614.v2.patch, YARN-1614.v3.patch, YARN-1614.v4.patch, YARN-1614.v5.patch
>
>
> job history server will only output the first 50 characters of the job names 
> in webUI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to