[ https://issues.apache.org/jira/browse/MAPREDUCE-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14587610#comment-14587610 ]
Gera Shegalov commented on MAPREDUCE-6395: ------------------------------------------ I would like to suggest following messages: # Job commit succeeded in a prior MRAppMaster attempt before it crashed. Recovering. # Job commit failed in a prior MRAppMaster attempt before it crashed. Not retrying. # Job commit from a prior MRAppMaster attempt is potentially in progress. Preventing multiple commit executions. # Job finished cleanly, recording last MRAppMaster retry > Improve the commit failure messages in MRAppMaster recovery > ----------------------------------------------------------- > > Key: MAPREDUCE-6395 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6395 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: applicationmaster > Affects Versions: 2.7.0 > Reporter: Gera Shegalov > Assignee: Brahma Reddy Battula > Labels: noob > > There are typos, and pluralis majestatis (royal we) or user-including "we" > messages that are confusing to the users: > {code} > if (commitSuccess) { > shutDownMessage = "We crashed after successfully committing. > Recovering."; > forcedState = JobStateInternal.SUCCEEDED; > } else if (commitFailure) { > shutDownMessage = "We crashed after a commit failure."; > forcedState = JobStateInternal.FAILED; > } else { > //The commit is still pending, commit error > shutDownMessage = "We crashed durring a commit"; > forcedState = JobStateInternal.ERROR; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)