[ https://issues.apache.org/jira/browse/MAPREDUCE-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592637#comment-14592637 ]
Jason Lowe commented on MAPREDUCE-6400: --------------------------------------- Sorry for arriving late. I'm a bit confused on the latest patch. We're going to close the IFileInputStream but only when something fails? That seems odd. In addition, note that IFileInputStream.close is not trivial -- it will consume the rest of the stream to verify the checksum, but we don't care since we're only trying to close when something else went wrong. At that point the checksum being valid is not important, correct? I'm thinking of a scenario where writing to the local disk fails early in a very large transfer. We don't want to spend time reading the rest of the data, rather we just want to abandon the transfer and move on. > TestReduceFetchFromPartialMem fails > ----------------------------------- > > Key: MAPREDUCE-6400 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6400 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: task > Affects Versions: 2.8.0 > Reporter: Akira AJISAKA > Assignee: Brahma Reddy Battula > Priority: Blocker > Attachments: MAPREDUCE-6400-002.patch, MAPREDUCE-6400.001.patch, > MAPREDUCE-6400.003.patch, MAPREDUCE-6400.patch > > > TestReduceFetchFromPartialMem fails. > {noformat} > Running org.apache.hadoop.mapred.TestReduceFetchFromPartialMem > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 132.978 sec > <<< FAILURE! - in org.apache.hadoop.mapred.TestReduceFetchFromPartialMem > testReduceFromPartialMem(org.apache.hadoop.mapred.TestReduceFetchFromPartialMem) > Time elapsed: 69.214 sec <<< ERROR! > java.io.IOException: Job failed! > at org.apache.hadoop.mapred.JobClient.runJob(JobClient.java:867) > at > org.apache.hadoop.mapred.TestReduceFetchFromPartialMem.runJob(TestReduceFetchFromPartialMem.java:300) > at > org.apache.hadoop.mapred.TestReduceFetchFromPartialMem.testReduceFromPartialMem(TestReduceFetchFromPartialMem.java:93) > Results : > Tests in error: > TestReduceFetchFromPartialMem.testReduceFromPartialMem:93->runJob:300 ยป IO > Job... > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)