[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702081#comment-14702081
 ] 

Jason Lowe commented on MAPREDUCE-5870:
---------------------------------------

Thanks for the patch, Sunil.  Looks good in general, but I think we need to 
decide what to do about JobConf.getJobPriority.  Currently it will return 
NORMAL if no priority was set but yet the job will _not_ submit with that 
priority in practice.  In addition JobConf.getJobPriority will crash if the 
priority wasn't set to one of the priority enum strings.

Not sure there's a great fix for these.  We could add a new enum, like DEFAULT 
or QUEUE_DEFAULT, which indicates the job priority has not been specified and 
we could at least do something symmetrical there.  A client can see that enum 
returned or even set it explicitly, and the submit code can treat that enum as 
if no priority was set.

The arbitrary priority value mapping to a mapred priority is trickier.  We 
could add an enum to indicate the priority doesn't map to one of the other 
standard values, but that would only provide half of the picture.  If a user 
set that priority explicitly then we wouldn't know what priority number 
corresponds.  However we could at least map the numerical values to the 
standard priority enums so we're symmetrical with the toYarn behavior.

> Support for passing Job priority through Application Submission Context in 
> Mapreduce Side
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5870
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5870
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: client
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-MAPREDUCE-5870.patch, 0002-MAPREDUCE-5870.patch, 
> 0003-MAPREDUCE-5870.patch, Yarn-2002.1.patch
>
>
> Job Prioirty can be set from client side as below [Configuration and api].
>                       a.      JobConf.getJobPriority() and 
> Job.setPriority(JobPriority priority) 
>                       b.      We can also use configuration 
> "mapreduce.job.priority".
>               Now this Job priority can be passed in Application Submission 
> context from Client side.
>               Here we can reuse the MRJobConfig.PRIORITY configuration. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to