[
https://issues.apache.org/jira/browse/MAPREDUCE-5003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906947#comment-14906947
]
Jason Lowe commented on MAPREDUCE-5003:
---------------------------------------
Thanks for updating the patch, Chang!
For backwards compatibility on the TaskAttemptStartedEvent avro change, is it
necessary to allow the value to be "null" or can we just leave it as an int and
default to -1? Also please enumerate how the backward and forward
compatibility was verified.
The javadoc for the new TaskAttemptStartedEvent constructor mentions a new
containerPort parameter without any details.
Nit: Ideally the following code should avoid the enum conversion if its
supposed to be in the RUNNING state. At a minimum we shouldn't be hardcoding
the name of enums as strings.
{code}
+ String taskStatus = taskInfo.getTaskStatus();
+ if(taskStatus == null) {
+ taskStatus = "RUNNING";
+ }
+ TaskStateInternal taskState = TaskStateInternal.valueOf(taskStatus);
{code}
> AM recovery should recreate records for attempts that were incomplete
> ---------------------------------------------------------------------
>
> Key: MAPREDUCE-5003
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5003
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mr-am
> Reporter: Jason Lowe
> Assignee: Chang Li
> Attachments: MAPREDUCE-5003.1.patch, MAPREDUCE-5003.2.patch,
> MAPREDUCE-5003.3.patch, MAPREDUCE-5003.4.patch, MAPREDUCE-5003.5.patch,
> MAPREDUCE-5003.5.patch, MAPREDUCE-5003.6.patch, MAPREDUCE-5003.7.patch,
> MAPREDUCE-5003.8.patch
>
>
> As discussed in MAPREDUCE-4992, it would be nice if the AM recovered task
> attempt entries for *all* task attempts launched by the prior app attempt
> even if those task attempts did not complete. The attempts would have to be
> marked as killed or something similar to indicate it is no longer running.
> Having records for the task attempts enables the user to see what nodes were
> associated with the attempts and potentially access their logs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
